Improve mobile/device behaviors for inline comments
ClosedPublic
Actions

Authored by epriestley on May 17 2017, 2:40 PM.

Tags

None

Referenced Files

	F18772506: D17928.id43126.diff
	Thu, Oct 9, 2:54 AM

	F18769502: D17928.diff
	Wed, Oct 8, 7:53 AM

	F18653130: D17928.id.diff
	Sun, Sep 21, 11:16 AM

	F18626340: D17928.id43122.diff
	Tue, Sep 16, 1:03 AM

	F18620144: D17928.diff
	Mon, Sep 15, 4:23 AM

	F18611857: D17928.diff
	Sun, Sep 14, 8:05 AM

	F18532576: D17928.diff
	Sep 7 2025, 7:39 AM

	F18508815: D17928.id.diff
	Sep 5 2025, 3:02 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T1026: Request: ability to select line range for comment via touchscreen
T12616: Modernize display code for inline comments

Commits

rP343f7cac72bb: Improve mobile/device behaviors for inline comments

Summary

Fixes T1026. Ref T12616. Allows drag-to-select on devices to add inlines on a range of lines, using dark magic that I copy/pasted from StackOverflow.

Test Plan

Left a comment on a range of lines on iPhone simulator.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 17 2017, 2:40 PM

Harbormaster completed remote builds in B17047: Diff 43122.May 17 2017, 2:41 PM

chad accepted this revision.May 17 2017, 3:06 PM

This revision is now accepted and ready to land.May 17 2017, 3:06 PM

Closed by commit rP343f7cac72bb: Improve mobile/device behaviors for inline comments (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2017, 3:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

52 lines

Diff 43126

View Options

resources/celerity/map.php