Page MenuHomePhabricator

Trigger autocomplete when "@" is typed on German keyboards
ClosedPublic

Authored by epriestley on Jul 8 2016, 3:20 PM.
Tags
None
Referenced Files
F18151726: D16259.id39109.diff
Thu, Aug 14, 6:43 PM
F18103303: D16259.id39111.diff
Sun, Aug 10, 3:58 AM
F18103172: D16259.id.diff
Sun, Aug 10, 2:31 AM
F18101955: D16259.id39109.diff
Sat, Aug 9, 5:03 PM
F18099864: D16259.id39111.diff
Sat, Aug 9, 9:10 AM
F18086889: D16259.id.diff
Wed, Aug 6, 12:59 AM
F18086571: D16259.id.diff
Tue, Aug 5, 10:49 PM
F18081684: D16259.diff
Tue, Aug 5, 1:34 AM
Subscribers
None

Details

Summary

Ref T10252. On the German keyboard layout, you must type "Alt" + "L" to generate an "@" character.

We currently ignore this event, assuming it's a keyboard command. However, I think we can safely continue so that autocomplete works on German layouts.

Test Plan
  • Switched keyboard layout to German.
  • Typed Alt + L to generate an "@".
  • Typed some username text.
  • Got autocompleter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable