Page MenuHomePhabricator

Fix "\" keyboard shortcut on German keyboard layouts
ClosedPublic

Authored by epriestley on Jul 8 2016, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 7:23 PM
Unknown Object (File)
Mon, Mar 18, 4:26 PM
Unknown Object (File)
Sun, Mar 10, 8:45 PM
Unknown Object (File)
Sun, Mar 10, 3:20 PM
Unknown Object (File)
Wed, Mar 6, 1:15 AM
Unknown Object (File)
Wed, Mar 6, 1:14 AM
Unknown Object (File)
Wed, Mar 6, 1:14 AM
Unknown Object (File)
Tue, Feb 27, 9:10 PM
Subscribers
None

Details

Summary

Ref T10252. This is similar to D16259, but makes KeyboardShortcutManager more relaxed about altKey when typing obscure characters.

Test Plan

Pressed Option + Shift + 7 on a German keyboard layout, saw Conphernece sidebar toggle.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix "\" keyboard shortcut on German keyboard layouts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 3:39 PM
This revision was automatically updated to reflect the committed changes.