Fix username typeahead in Remarkup with German keyboard layout
ClosedPublic
Actions

Authored by chad on Jul 24 2017, 12:26 PM.

Details

Reviewers

benwick
epriestley

Maniphest Tasks

T10252: Username autocompletion doesn't work with some non-US keyboard layouts

Commits

rP020f3c729a0a: Fix username typeahead in Remarkup with German keyboard layout

Summary

Ref T10252. The previous fix rPa8a9fddb0738 only works for macOS.
Under Windows the @ symbol is composed of AltGr+q. For Chrome and Edge the "AltGr" keypressEvent is like pressing the Control key and the Alt key at the same time.
This fix changes the condition in such a way, that this case (pressing Control and Alt at the same time) is not blocked.

Test Plan

Testing for the issue:

Launch Windows 10, Select German Keyboard, Use latest Chrome (60)
Observe typing @ does not trigger typeahead
Apply patch, retest, see typeahead.

Regression tested:

Windows 10, Chrome, Firefox, Edge
Mac OS, Chrome, Firefox, Safari
Keyboard layouts, English, French, German, Spanish

All tests passed

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

benwick created this revision.Jul 24 2017, 12:26 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 24 2017, 12:26 PM

Herald added a subscriber: epriestley. · View Herald Transcript

OCram awarded a token.Jul 24 2017, 1:02 PM

Let me try to scare up some decent way to test this today then I can just let it fly and revert if we get more tasks about it.

chad commandeered this revision.Aug 3 2017, 4:30 PM

chad edited reviewers, added: benwick; removed: chad.

Harbormaster failed remote builds in B17784: Diff 43936!Aug 3 2017, 4:30 PM

add celerity map

Harbormaster completed remote builds in B17889: Diff 44065.Aug 3 2017, 4:32 PM

chad edited the test plan for this revision. (Show Details)Aug 3 2017, 5:12 PM

chad edited reviewers, added: epriestley; removed: Blessed Reviewers.

@epriestley I am comfortable enough to ship this - at least I tested it reasonably well.

Here's, e.g., a user complaining that another piece of software implemented a similar behavior, hijacking ⌃+Alt+V which they intend to mean "Paste Special":

https://superuser.com/questions/403011/evernote-hijacked-my-ctrlaltv-shortcut-how-can-i-get-it-back

However, we don't hijack the keystroke and don't autocomplete on "V", so I think this is fine until we run into tangible issues with it.

This revision is now accepted and ready to land.Aug 3 2017, 5:44 PM

(I also think "Paste Special" probably isn't meaningful in browsers, I think that user was maybe using a Windows extension or toolbar or something, not complaining about website/browser behavior.)

Closed by commit rP020f3c729a0a: Fix username typeahead in Remarkup with German keyboard layout (authored by chad, committed by chad). · Explain WhyAug 3 2017, 5:46 PM

This revision was automatically updated to reflect the committed changes.