Page MenuHomePhabricator
Differential D9639

Update callsites of `phutil_json_decode`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 20 2014, 8:20 AM.
Tags
None
Referenced Files
F14109229: D9639.id23128.diff
Wed, Nov 27, 1:56 PM
F14102630: D9639.id23134.diff
Tue, Nov 26, 7:42 PM
Unknown Object (File)
Tue, Nov 26, 5:34 PM
Unknown Object (File)
Sun, Nov 24, 4:01 AM
Unknown Object (File)
Sun, Nov 24, 4:00 AM
Unknown Object (File)
Sun, Nov 17, 7:48 PM
Unknown Object (File)
Mon, Nov 11, 2:37 PM
Unknown Object (File)
Sun, Nov 10, 6:36 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU8845b0329c95: Update callsites of `phutil_json_decode`.
Summary

Depends on D9634. phutil_json_decode now throws an exception on invalid JSON.

Test Plan

Not really sure how to test this?

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23128.Jun 20 2014, 8:20 AM
joshuaspence retitled this revision from to Update callsites of `phutil_json_decode`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D9634: Modify `phutil_json_decode` to use `PhutilJSONParser`..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 8:20 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1262: Diff 23128.Jun 20 2014, 8:21 AM
epriestley accepted this revision.Jun 20 2014, 12:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2014, 12:36 PM
joshuaspence closed this revision.Jun 20 2014, 2:39 PM
joshuaspence updated this revision to Diff 23134.

Closed by commit rPHU8845b0329c95 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
future/
wordpress/
10 lines

Diff 23134

View Options

src/future/wordpress/PhutilWordPressFuture.php

Loading...
Phabricator · Built by Phacility