Page MenuHomePhabricator
Differential D9624

Throw better exceptions from `PhutilJSONParser`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 18 2014, 7:02 PM.
Tags
None
Referenced Files
F14752923: D9624.id23106.diff
Tue, Jan 21, 1:56 PM
F14752901: D9624.id23084.diff
Tue, Jan 21, 1:55 PM
F14749914: D9624.id.diff
Tue, Jan 21, 11:37 AM
Unknown Object (File)
Mon, Jan 20, 2:18 PM
Unknown Object (File)
Fri, Jan 17, 11:45 AM
Unknown Object (File)
Wed, Jan 15, 7:25 AM
Unknown Object (File)
Sat, Jan 11, 4:41 PM
Unknown Object (File)
Tue, Dec 24, 3:53 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5297: Create a native JSON parser.
Commits
rPHUf9730519f42c: Throw better exceptions from `PhutilJSONParser`.
Summary

Ref T5297. Retrieve error context from JsonLintParsingException to provide a better exception message.

Depends on D9623.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23084.Jun 18 2014, 7:02 PM
joshuaspence retitled this revision from to Throw better exceptions from `PhutilJSONParser`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5297: Create a native JSON parser..
joshuaspence added a parent revision: D9623: Modify the JsonLint library to return `array` instead of `stdClass`..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2014, 7:02 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1232: Diff 23084.Jun 18 2014, 7:03 PM
joshuaspence planned changes to this revision.Jun 18 2014, 11:24 PM

I'm sure I can get a column number in here as well

joshuaspence updated this revision to Diff 23090.Jun 19 2014, 12:35 AM
joshuaspence edited edge metadata.
  • Better error messages
Harbormaster completed remote builds in B1237: Diff 23090.Jun 19 2014, 12:36 AM
epriestley accepted this revision.Jun 19 2014, 6:01 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 19 2014, 6:01 PM
joshuaspence updated this revision to Diff 23106.Jun 19 2014, 10:55 PM
joshuaspence edited edge metadata.

Rebase

Harbormaster completed remote builds in B1247: Diff 23106.Jun 19 2014, 10:56 PM
joshuaspence added a parent revision: D9633: Fix the handling of empty keys in `PhutilJSONParser`..Jun 20 2014, 12:24 AM
joshuaspence requested a review of this revision.Jun 20 2014, 12:27 AM
joshuaspence edited edge metadata.

I changed the way in which parameters are passed to the constructor, does this fly with you?

epriestley accepted this revision.Jun 20 2014, 1:51 AM
epriestley edited edge metadata.

Yep, looks good to me.

src/parser/PhutilJSONParser.php
25–30

(Extra indent.)

This revision is now accepted and ready to land.Jun 20 2014, 1:51 AM
joshuaspence closed this revision.Jun 20 2014, 1:55 AM
joshuaspence updated this revision to Diff 23116.

Closed by commit rPHUf9730519f42c (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
parser/
10 lines
__tests__/
55 lines
exception/
40 lines

Diff 23116

View Options

src/parser/PhutilJSONParser.php

Loading...
View Options

src/parser/__tests__/PhutilJSONParserTestCase.php

Loading...
View Options

src/parser/exception/PhutilJSONParserException.php

Loading...
Phabricator · Built by Phacility