Paths

Table of Contentst

Update callsites of `phutil_json_decode`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 20 2014, 8:29 AM.

Tags

None

Referenced Files

	F18335189: D9641.diff
	Mon, Aug 25, 6:09 AM

	F18228758: D9641.id.diff
	Wed, Aug 20, 8:00 AM

	F18219458: D9641.diff
	Tue, Aug 19, 11:39 AM

	F18199973: D9641.id23135.diff
	Mon, Aug 18, 3:15 AM

	F18111629: D9641.id.diff
	Tue, Aug 12, 11:13 AM

	F18030684: D9641.id23131.diff
	Sat, Aug 2, 11:44 PM

	F17953050: D9641.id.diff
	Fri, Aug 1, 2:43 AM

	F17939147: D9641.diff
	Thu, Jul 31, 2:52 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC5ee12bbad652: Update callsites of `phutil_json_decode`.

Summary

Depends on D9634. phutil_json_decode now throws an exception on invalid JSON.

Test Plan

Ran the unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23131.Jun 20 2014, 8:29 AM

joshuaspence retitled this revision from to Update callsites of `phutil_json_decode`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D9634: Modify `phutil_json_decode` to use `PhutilJSONParser`..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 8:29 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1264: Diff 23131.Jun 20 2014, 8:30 AM

epriestley accepted this revision.Jun 20 2014, 12:37 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 20 2014, 12:37 PM

Closed by commit rARC5ee12bbad652 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

ArcanistLinterTestCase.php

5 lines

Diff 23135

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

Update callsites of `phutil_json_decode`.ClosedPublicActions