Fix `PhutilReadableSerializer` to quote strings.
ClosedPublic
Actions

Authored by joshuaspence on Jun 19 2014, 8:35 PM.

Tags

None

Referenced Files

	F14492542: D9632.id23100.diff
	Thu, Jan 2, 8:20 PM

	Unknown Object (File)
	Sat, Dec 21, 3:08 PM

	Unknown Object (File)
	Nov 30 2024, 7:13 PM

	Unknown Object (File)
	Nov 28 2024, 9:01 PM

	Unknown Object (File)
	Nov 27 2024, 7:12 PM

	Unknown Object (File)
	Nov 27 2024, 5:54 AM

	Unknown Object (File)
	Nov 23 2024, 6:37 AM

	Unknown Object (File)
	Nov 21 2024, 9:49 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUd8935319d556: Fix `PhutilReadableSerializer` to quote strings.

Summary

See D9622#inline-37279 for explanation.

Test Plan

Modified and ran unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23100.Jun 19 2014, 8:35 PM

joshuaspence retitled this revision from to Fix `PhutilReadableSerializer` to quote strings..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 19 2014, 8:35 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1245: Diff 23100.Jun 19 2014, 8:36 PM

epriestley accepted this revision.Jun 19 2014, 8:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 19 2014, 8:44 PM

Closed by commit rPHUd8935319d556 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

readableserializer/

PhutilReadableSerializer.php

9 lines

__tests__/

PhutilReadableSerializerTestCase.php

2 lines

Diff 23101

View Options

src/readableserializer/PhutilReadableSerializer.php

View Options

src/readableserializer/tests/PhutilReadableSerializerTestCase.php

Fix `PhutilReadableSerializer` to quote strings.ClosedPublicActions