Tags

None

Referenced Files

	F18335197: D9632.diff
	Mon, Aug 25, 6:09 AM

	F18236653: D9632.id.diff
	Wed, Aug 20, 8:25 PM

	F18220971: D9632.diff
	Tue, Aug 19, 5:03 PM

	F17726917: D9632.diff
	Jul 18 2025, 9:04 PM

	Unknown Object (File)
	Jun 18 2025, 9:19 PM

	Unknown Object (File)
	Jun 18 2025, 5:56 PM

	Unknown Object (File)
	Jun 18 2025, 5:54 PM

	Unknown Object (File)
	Jun 17 2025, 4:50 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUd8935319d556: Fix `PhutilReadableSerializer` to quote strings.

Summary

See D9622#inline-37279 for explanation.

Test Plan

Modified and ran unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23100.Jun 19 2014, 8:35 PM

joshuaspence retitled this revision from to Fix `PhutilReadableSerializer` to quote strings..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 19 2014, 8:35 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1245: Diff 23100.Jun 19 2014, 8:36 PM

epriestley accepted this revision.Jun 19 2014, 8:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 19 2014, 8:44 PM

Closed by commit rPHUd8935319d556 (authored by @joshuaspence).

Fix `PhutilReadableSerializer` to quote strings.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 23101

src/readableserializer/PhutilReadableSerializer.php

src/readableserializer/tests/PhutilReadableSerializerTestCase.php

Fix `PhutilReadableSerializer` to quote strings.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23101

src/readableserializer/PhutilReadableSerializer.php

src/readableserializer/__tests__/PhutilReadableSerializerTestCase.php

Fix `PhutilReadableSerializer` to quote strings.
ClosedPublic
Actions

Revision Contents
Changeset List

src/readableserializer/tests/PhutilReadableSerializerTestCase.php