Paths

Table of Contentst

Differential D9633

Fix the handling of empty keys in `PhutilJSONParser`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 20 2014, 12:21 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU3bd9044d42bb: Fix the handling of empty keys in `PhutilJSONParser`.

Summary

Because the empty string is not a valid property of stdClass, the original JsonLint library replaced empty keys with '_empty_'. After D9623, all instances of stdClass have been replaced by arrays, so we can remove this nonsense.

Depends on D9623.

Test Plan

Added a test case and ran arc unit.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23110.Jun 20 2014, 12:21 AM

joshuaspence retitled this revision from to Fix the handling of empty keys in `PhutilJSONParser`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D9623: Modify the JsonLint library to return `array` instead of `stdClass`..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 12:21 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1251: Diff 23110.Jun 20 2014, 12:22 AM

epriestley accepted this revision.Jun 20 2014, 12:26 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 20 2014, 12:26 AM

Closed by commit rPHU3bd9044d42bb (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

externals/

jsonlint/

src/

Seld/

JsonLint/

JsonParser.php

4 lines

src/

parser/

__tests__/

PhutilJSONParserTestCase.php

1 line

Diff 23112

View Options

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

View Options

src/parser/tests/PhutilJSONParserTestCase.php

Fix the handling of empty keys in `PhutilJSONParser`.ClosedPublicActions