Page MenuHomePhabricator
Differential D9633

Fix the handling of empty keys in `PhutilJSONParser`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 20 2014, 12:21 AM.
Tags
None
Referenced Files
F14109693: D9633.diff
Wed, Nov 27, 3:06 PM
F14103243: D9633.id.diff
Tue, Nov 26, 9:29 PM
Unknown Object (File)
Sun, Nov 24, 2:58 AM
Unknown Object (File)
Sat, Nov 23, 7:28 AM
Unknown Object (File)
Mon, Nov 18, 10:38 PM
Unknown Object (File)
Thu, Nov 14, 10:52 PM
Unknown Object (File)
Mon, Nov 11, 12:16 AM
Unknown Object (File)
Wed, Nov 6, 7:04 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU3bd9044d42bb: Fix the handling of empty keys in `PhutilJSONParser`.
Summary

Because the empty string is not a valid property of stdClass, the original JsonLint library replaced empty keys with '_empty_'. After D9623, all instances of stdClass have been replaced by arrays, so we can remove this nonsense.

Depends on D9623.

Test Plan

Added a test case and ran arc unit.

Diff Detail

Repository
rPHU libphutil
Branch
json2.5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1251
Build 1251: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23110.Jun 20 2014, 12:21 AM
joshuaspence retitled this revision from to Fix the handling of empty keys in `PhutilJSONParser`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D9623: Modify the JsonLint library to return `array` instead of `stdClass`..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 12:21 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1251: Diff 23110.Jun 20 2014, 12:22 AM
epriestley accepted this revision.Jun 20 2014, 12:26 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2014, 12:26 AM
joshuaspence closed this revision.Jun 20 2014, 12:27 AM
joshuaspence updated this revision to Diff 23112.

Closed by commit rPHU3bd9044d42bb (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
externals/
jsonlint/
src/
Seld/
JsonLint/
4 lines
src/
parser/
__tests__/
1 line

Diff 23110

View Options

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

Loading...
View Options

src/parser/__tests__/PhutilJSONParserTestCase.php

Loading...
Phabricator · Built by Phacility