Page MenuHomePhabricator

Throw better exceptions from `PhutilJSONParser`.
ClosedPublic

Authored by joshuaspence on Jun 18 2014, 7:02 PM.
Tags
None
Referenced Files
F14010189: D9624.id23106.diff
Thu, Oct 31, 6:23 AM
F13994972: D9624.id23106.diff
Wed, Oct 23, 9:48 AM
F13988044: D9624.id23084.diff
Mon, Oct 21, 12:48 PM
F13985031: D9624.id23106.diff
Sun, Oct 20, 5:37 PM
F13984963: D9624.id.diff
Sun, Oct 20, 5:12 PM
F13984940: D9624.id23116.diff
Sun, Oct 20, 5:02 PM
F13984937: D9624.id.diff
Sun, Oct 20, 5:01 PM
F13984818: D9624.diff
Sun, Oct 20, 4:11 PM
Subscribers

Details

Summary

Ref T5297. Retrieve error context from JsonLintParsingException to provide a better exception message.

Depends on D9623.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
json3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1247
Build 1247: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Throw better exceptions from `PhutilJSONParser`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

I'm sure I can get a column number in here as well

joshuaspence edited edge metadata.
  • Better error messages
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 19 2014, 6:01 PM
joshuaspence edited edge metadata.

I changed the way in which parameters are passed to the constructor, does this fly with you?

epriestley edited edge metadata.

Yep, looks good to me.

src/parser/PhutilJSONParser.php
32–37

(Extra indent.)

This revision is now accepted and ready to land.Jun 20 2014, 1:51 AM