Make XHPAST unit test "expect" blocks stable and human-readable
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:08 PM.

Details

Reviewers: None
Maniphest Tasks: T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits: rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable

Summary

Depends on D21064. Ref T13492. Earlier, see D17819. This is essentially the same change, although I inlined the token stream into the node list.

This intentionally breaks most tests since it just has the new "expect" generator; the next change will fix them by swapping the test bodies.

Test Plan

Ran "arc unit --everything" after the next change (which fixes all the tests), got a clean build. This change on its own fails all existing XHPAST tests since the block formats don't match.

Diff Detail

Repository

rARC Arcanist

Branch

xhpast3

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 24003
Build 33036: Run Core Tests
Build 33035: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	24 ms	PHPASTParserTestCase::testParser Assertion failed, expected values to be equal (at PHPASTParserTestCase.php:105): Parser output for "anonymous_class.php.test". Expected vs Actual Output Diff --- Old Value
	19 ms	PHPASTParserTestCase::testParser Assertion failed, expected values to be equal (at PHPASTParserTestCase.php:105): Parser output for "anonymous_class.php.test". Expected vs Actual Output Diff --- Old Value
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
		View Full Test Results (2 Failed · 464 Passed · 34 Skipped)