Make XHPAST unit test "expect" blocks stable and human-readable
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:08 PM.

Details

Reviewers: None
Maniphest Tasks: T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits: rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable

Summary

Depends on D21064. Ref T13492. Earlier, see D17819. This is essentially the same change, although I inlined the token stream into the node list.

This intentionally breaks most tests since it just has the new "expect" generator; the next change will fix them by swapping the test bodies.

Test Plan

Ran "arc unit --everything" after the next change (which fixes all the tests), got a clean build. This change on its own fails all existing XHPAST tests since the block formats don't match.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 7 2020, 9:08 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2020, 9:09 PM

Harbormaster failed remote builds in B24003: Diff 50184!

epriestley mentioned this in D17819: Make PHPAST parser tests stable and human-readable.Apr 7 2020, 9:09 PM

epriestley added a child revision: D21066: Update XHPAST "expect" test blocks to the new stable, human-readable format.Apr 7 2020, 9:11 PM

Test failures are expected.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 9:32 PM

This revision was landed with ongoing or failed builds.

Closed by commit rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

PHPASTParserTestCase.php

244 lines

data/

a-self-test.php.test

45 lines

base-fail-parse.php.test

php-heredoc-terminal.php.test

Diff 50190

View Options

src/parser/xhpast/tests/PHPASTParserTestCase.php

View Options

src/parser/xhpast/tests/data/a-self-test.php.test

View Options

src/parser/xhpast/tests/data/base-fail-parse.php.test

View Options

src/parser/xhpast/tests/data/php-heredoc-terminal.php.test

Make XHPAST unit test "expect" blocks stable and human-readableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50190

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

src/parser/xhpast/__tests__/data/a-self-test.php.test

src/parser/xhpast/__tests__/data/base-fail-parse.php.test

src/parser/xhpast/__tests__/data/php-heredoc-terminal.php.test

Make XHPAST unit test "expect" blocks stable and human-readable
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/PHPASTParserTestCase.php

src/parser/xhpast/tests/data/a-self-test.php.test

src/parser/xhpast/tests/data/base-fail-parse.php.test

src/parser/xhpast/tests/data/php-heredoc-terminal.php.test