Page MenuHomePhabricator

When a page throws an exception and response construction throws another exception, throw an aggregate exception
ClosedPublic

Authored by epriestley on Aug 16 2019, 10:20 PM.
Tags
None
Referenced Files
F15478168: D20720.diff
Mon, Apr 7, 8:56 PM
F15469773: D20720.diff
Fri, Apr 4, 4:34 PM
F15463052: D20720.id49437.diff
Tue, Apr 1, 8:04 PM
F15463051: D20720.id49402.diff
Tue, Apr 1, 8:04 PM
F15463050: D20720.id.diff
Tue, Apr 1, 8:04 PM
F15460449: D20720.diff
Mon, Mar 31, 11:06 PM
F15445817: D20720.id.diff
Thu, Mar 27, 4:10 PM
F15414876: D20720.diff
Thu, Mar 20, 2:56 AM
Subscribers
None

Details

Summary

Depends on D20719. Currently, if a page throws an exception (like a policy exception) and rendering that exception into a response (like a policy dialog) throws another exception (for example, while constructing breadcrumbs), we only show the orginal exception.

This is usually the more useful exception, but sometimes we actually care about the other exception.

Instead of guessing which one is more likely to be useful, throw them both as an "AggregateException" and let the high-level handler flatten it for display.

Test Plan

Screen Shot 2019-08-16 at 3.18.18 PM.png (1×1 px, 413 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable