Page MenuHomePhabricator

Make Phortune payment methods transaction-oriented and always support "Add Payment Method"
ClosedPublic

Authored by epriestley on Aug 16 2019, 9:56 PM.
Tags
None
Referenced Files
F19098738: D20719.id49401.diff
Thu, Dec 4, 5:57 PM
F19083029: D20719.id49436.diff
Tue, Dec 2, 12:29 PM
F19026361: D20719.id.diff
Mon, Nov 24, 10:37 AM
F18985163: D20719.id49401.diff
Nov 17 2025, 12:54 PM
F18961252: D20719.diff
Nov 13 2025, 1:35 PM
F18870239: D20719.diff
Nov 4 2025, 4:06 PM
F18865381: D20719.id.diff
Nov 3 2025, 11:59 AM
F18859785: D20719.diff
Nov 2 2025, 6:29 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20718. Ref T13366. Ref T13367.

  • Phortune payment methods currently do not use transactions; update them.
  • Give them a proper view page with a transaction log.
  • Add an "Add Payment Method" button which always works.
  • Show which subscriptions a payment method is associated with.
  • Get rid of the "Active" status indicator since we now treat "disabled" as "removed", to align with user expectation/intent.
  • Swap out of some of the super weird div-form-button UI into the new "big, clickable" UI for choice dialogs among a small number of options on a single dimension.
Test Plan
  • As a mechant-authority and account-authority, created payment methods from carts, subscriptions, and accounts. Edited and viewed payment methods.

Diff Detail

Repository
rP Phabricator
Branch
merchant8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23261
Build 31957: Run Core Tests
Build 31956: arc lint + arc unit