Page MenuHomePhabricator

Make Phortune payment methods transaction-oriented and always support "Add Payment Method"
ClosedPublic

Authored by epriestley on Aug 16 2019, 9:56 PM.
Tags
None
Referenced Files
F12858434: D20719.id49436.diff
Fri, Mar 29, 11:30 AM
Unknown Object (File)
Feb 16 2024, 3:10 PM
Unknown Object (File)
Feb 10 2024, 10:06 PM
Unknown Object (File)
Jan 20 2024, 4:44 PM
Unknown Object (File)
Jan 16 2024, 5:50 PM
Unknown Object (File)
Jan 12 2024, 5:39 PM
Unknown Object (File)
Jan 8 2024, 4:46 PM
Unknown Object (File)
Jan 4 2024, 4:10 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20718. Ref T13366. Ref T13367.

  • Phortune payment methods currently do not use transactions; update them.
  • Give them a proper view page with a transaction log.
  • Add an "Add Payment Method" button which always works.
  • Show which subscriptions a payment method is associated with.
  • Get rid of the "Active" status indicator since we now treat "disabled" as "removed", to align with user expectation/intent.
  • Swap out of some of the super weird div-form-button UI into the new "big, clickable" UI for choice dialogs among a small number of options on a single dimension.
Test Plan
  • As a mechant-authority and account-authority, created payment methods from carts, subscriptions, and accounts. Edited and viewed payment methods.

Diff Detail

Repository
rP Phabricator
Branch
merchant8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23261
Build 31957: Run Core Tests
Build 31956: arc lint + arc unit