Page MenuHomePhabricator

Respect repository identities when selecting author vs auditor actions
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 11:38 AM
Unknown Object (File)
Fri, Nov 15, 6:00 PM
Unknown Object (File)
Tue, Nov 12, 1:43 PM
Unknown Object (File)
Fri, Nov 8, 8:57 AM
Unknown Object (File)
Thu, Nov 7, 7:18 AM
Unknown Object (File)
Thu, Oct 31, 4:29 AM
Unknown Object (File)
Oct 26 2024, 5:58 AM
Unknown Object (File)
Oct 22 2024, 9:18 PM
Subscribers
None

Details

Summary

Depends on D20580. Fixes T13311. When we choose which actions to show a user, we can either show them "auditor" actions (like "raise concern") or "author" actions (like "request verification").

Currently, we don't show "author" actions if you're the author of the commit via an identity mapping, but we should. Use identity mappings where they exist.

(Because I've implemented getEffectiveAuthorPHID() in a way that requires $data be attached, it's possible this will make something throw a "DataNotAttached" exception, but: probably it won't?; and that's easy to fix if it happens.)

Test Plan

See D20580. As @alice, viewed the commit in the UI.

  • Before: got auditor actions presented to me.
  • After: got author actions.

Diff Detail

Repository
rP Phabricator
Branch
audit2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22961
Build 31512: Run Core Tests
Build 31511: arc lint + arc unit