Page MenuHomePhabricator
Differential D20496

Consolidate burndown logic into a "BurndownChartEngine"
ClosedPublic
Actions

Authored by epriestley on May 3 2019, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 5:00 PM
Unknown Object (File)
Wed, Jan 29, 8:21 AM
Unknown Object (File)
Tue, Jan 28, 5:15 AM
Unknown Object (File)
Tue, Jan 28, 5:15 AM
Unknown Object (File)
Tue, Jan 28, 5:15 AM
Unknown Object (File)
Sat, Jan 25, 4:33 PM
Unknown Object (File)
Sat, Jan 25, 5:01 AM
Unknown Object (File)
Sat, Jan 25, 5:01 AM
View All Files
Subscribers
yelirekim

Details

Reviewers
amckinley
Maniphest Tasks
T13279: Build Charting for Facts
Commits
rP5c1b91ab457d: Consolidate burndown logic into a "BurndownChartEngine"
Summary

Ref T13279. For now, we need to render burndowns from both Maniphest (legacy) and Projects (new prototype).

Consolidate this logic into a "BurndownChartEngine". I plan to expand this to work a bit like a "SearchEngine", and serve as a UI layer on top of the raw chart features.

The old "ChartEngine" is now "ChartRenderingEngine".

Test Plan
  • Viewed burndowns ("burnups") in Maniphest.
  • Viewed burndowns in Projects.
  • Saw the same chart.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
paneltype/
4 lines
fact/
controller/
4 lines
engine/
226 lines
PhabricatorChartRenderingEngine.php
PhabricatorChartEngine.php
2 lines
maniphest/
controller/
51 lines
project/
chart/
71 lines
controller/
44 lines

Diff 48997

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardChartPanelType.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactChartController.php

Loading...
View Options

src/applications/fact/engine/PhabricatorChartEngine.php

Loading...
View Options

src/applications/fact/engine/PhabricatorChartRenderingEngine.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectReportsController.php

Loading...
Phabricator · Built by Phacility