Page MenuHomePhabricator

Consolidate burndown logic into a "BurndownChartEngine"
ClosedPublic

Authored by epriestley on May 3 2019, 7:16 PM.
Tags
None
Referenced Files
F12847208: D20496.id.diff
Fri, Mar 29, 1:57 AM
Unknown Object (File)
Tue, Mar 5, 2:33 AM
Unknown Object (File)
Feb 20 2024, 8:12 AM
Unknown Object (File)
Feb 7 2024, 10:34 PM
Unknown Object (File)
Feb 3 2024, 10:24 PM
Unknown Object (File)
Jan 19 2024, 2:08 AM
Unknown Object (File)
Dec 23 2023, 10:56 PM
Unknown Object (File)
Dec 22 2023, 2:13 AM
Subscribers

Details

Summary

Ref T13279. For now, we need to render burndowns from both Maniphest (legacy) and Projects (new prototype).

Consolidate this logic into a "BurndownChartEngine". I plan to expand this to work a bit like a "SearchEngine", and serve as a UI layer on top of the raw chart features.

The old "ChartEngine" is now "ChartRenderingEngine".

Test Plan
  • Viewed burndowns ("burnups") in Maniphest.
  • Viewed burndowns in Projects.
  • Saw the same chart.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable