Differential D20496

Consolidate burndown logic into a "BurndownChartEngine"
ClosedPublic
Actions

Authored by epriestley on May 3 2019, 7:16 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13279: Build Charting for Facts

Commits

rP5c1b91ab457d: Consolidate burndown logic into a "BurndownChartEngine"

Summary

Ref T13279. For now, we need to render burndowns from both Maniphest (legacy) and Projects (new prototype).

Consolidate this logic into a "BurndownChartEngine". I plan to expand this to work a bit like a "SearchEngine", and serve as a UI layer on top of the raw chart features.

The old "ChartEngine" is now "ChartRenderingEngine".

Test Plan

Viewed burndowns ("burnups") in Maniphest.
Viewed burndowns in Projects.
Saw the same chart.

Diff Detail

Repository

rP Phabricator

Branch

chart20

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22761
Build 31210: Run Core Tests
Build 31209: arc lint + arc unit

Event Timeline

epriestley created this revision.May 3 2019, 7:16 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptMay 3 2019, 7:16 PM

Harbormaster completed remote builds in B22761: Diff 48888.May 3 2019, 7:18 PM

epriestley requested review of this revision.May 3 2019, 7:18 PM

amckinley accepted this revision.May 21 2019, 9:35 PM

This revision is now accepted and ready to land.May 21 2019, 9:35 PM

Closed by commit rP5c1b91ab457d: Consolidate burndown logic into a "BurndownChartEngine" (authored by epriestley). · Explain WhyMay 22 2019, 12:10 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5c1b91ab457d: Consolidate burndown logic into a "BurndownChartEngine".

epriestley mentioned this in rP5c1b91ab457d: Consolidate burndown logic into a "BurndownChartEngine".

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

dashboard/

paneltype/

PhabricatorDashboardChartPanelType.php

4 lines

fact/

controller/

PhabricatorFactChartController.php

4 lines

engine/

PhabricatorChartEngine.php

226 lines

	PhabricatorChartRenderingEngine.php
	PhabricatorChartEngine.php

2 lines

maniphest/

controller/

ManiphestReportController.php

51 lines

project/

chart/

PhabricatorProjectBurndownChartEngine.php

71 lines

controller/

PhabricatorProjectReportsController.php

44 lines

Diff 48888

View Options

src/__phutil_library_map__.php

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardChartPanelType.php

View Options

src/applications/fact/controller/PhabricatorFactChartController.php

View Options

src/applications/fact/engine/PhabricatorChartEngine.php

View Options

src/applications/fact/engine/PhabricatorChartRenderingEngine.php

View Options

src/applications/maniphest/controller/ManiphestReportController.php

View Options

src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php

View Options

src/applications/project/controller/PhabricatorProjectReportsController.php

Consolidate burndown logic into a "BurndownChartEngine"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48888

src/__phutil_library_map__.php

src/applications/dashboard/paneltype/PhabricatorDashboardChartPanelType.php

src/applications/fact/controller/PhabricatorFactChartController.php

src/applications/fact/engine/PhabricatorChartEngine.php

src/applications/fact/engine/PhabricatorChartRenderingEngine.php

src/applications/maniphest/controller/ManiphestReportController.php

src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php

src/applications/project/controller/PhabricatorProjectReportsController.php

Consolidate burndown logic into a "BurndownChartEngine"
ClosedPublic
Actions

Revision Contents
Changeset List