Page MenuHomePhabricator

Consolidate burndown logic into a "BurndownChartEngine"
ClosedPublic

Authored by epriestley on May 3 2019, 7:16 PM.

Details

Summary

Ref T13279. For now, we need to render burndowns from both Maniphest (legacy) and Projects (new prototype).

Consolidate this logic into a "BurndownChartEngine". I plan to expand this to work a bit like a "SearchEngine", and serve as a UI layer on top of the raw chart features.

The old "ChartEngine" is now "ChartRenderingEngine".

Test Plan
  • Viewed burndowns ("burnups") in Maniphest.
  • Viewed burndowns in Projects.
  • Saw the same chart.

Diff Detail

Repository
rP Phabricator
Branch
chart20
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22761
Build 31210: Run Core Tests
Build 31209: arc lint + arc unit

Event Timeline

epriestley created this revision.May 3 2019, 7:16 PM
epriestley requested review of this revision.May 3 2019, 7:18 PM
amckinley accepted this revision.May 21 2019, 9:35 PM
This revision is now accepted and ready to land.May 21 2019, 9:35 PM