Differential D20418
Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories Authored by epriestley on Apr 14 2019, 5:51 PM. Tags None Referenced Files
Subscribers None
Details
Ref T12164. Ref T13276. Currently, the parsing pipeline copies the author and committer names and PHIDs into the transcaction record as metadata. They are then rendered directly from the metadata. This makes planned changes to the parsing pipeline (to prevent races when multiple commits matching a single revision are pushed simultaneously) more difficult, and generally won't work with repository identities. Instead, load the commit and use its identities. Loaded a revision, saw the same story rendering for a "Closed by commit" story.
Diff Detail
Event Timeline
Comment Actions We could, possibly. There are some old "action" transactions we should also clean up at some point. I suspect we may do a round of transaction data cleaning once Facts comes online, since Facts depends on doing ETL on the transaction record, and at least some issues are probably easier to fix by rewriting the transaction record than by adding hacky code to handle old transactions to Facts analyzers. | ||||||||||||||||||||||||||||||||||||