Page MenuHomePhabricator
Differential D20337

Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installed
ClosedPublic
Actions

Authored by epriestley on Mar 27 2019, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 3:59 PM
Unknown Object (File)
Sun, Nov 17, 1:42 AM
Unknown Object (File)
Mon, Nov 4, 6:35 PM
Unknown Object (File)
Oct 21 2024, 5:52 AM
Unknown Object (File)
Oct 9 2024, 11:56 AM
Unknown Object (File)
Oct 5 2024, 5:32 AM
Unknown Object (File)
Oct 3 2024, 4:53 AM
Unknown Object (File)
Sep 6 2024, 6:01 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12745: Conpherence menu item is available for creation even if Conpherence is not installed
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Commits
rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if…
Summary

Depends on D20336. Ref T13272. Fixes T12745. If you uninstall Conpherence, "Edit Favorites" and other editable menu interfaces still allow you to add "Conpherence" items. Prevent this.

Test Plan
  • Installed Conpherence: Saw option to add a "Conpherence" link when editing favorites menu.
  • Uninstalled Conpherence: No more option.

Diff Detail

Repository
rP Phabricator
Branch
panel5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22404
Build 30656: Run Core Tests
Build 30655: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
search/
menuitem/
6 lines

Diff 48533

View Options

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Loading...
Phabricator · Built by Phacility