Page MenuHomePhabricator

Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installed
ClosedPublic

Authored by epriestley on Mar 27 2019, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 4:06 AM
Unknown Object (File)
Feb 11 2024, 6:59 AM
Unknown Object (File)
Feb 8 2024, 9:25 PM
Unknown Object (File)
Feb 3 2024, 9:55 PM
Unknown Object (File)
Feb 2 2024, 7:23 AM
Unknown Object (File)
Jan 6 2024, 4:40 PM
Unknown Object (File)
Dec 27 2023, 3:19 AM
Unknown Object (File)
Dec 26 2023, 7:28 PM
Subscribers
None

Details

Summary

Depends on D20336. Ref T13272. Fixes T12745. If you uninstall Conpherence, "Edit Favorites" and other editable menu interfaces still allow you to add "Conpherence" items. Prevent this.

Test Plan
  • Installed Conpherence: Saw option to add a "Conpherence" link when editing favorites menu.
  • Uninstalled Conpherence: No more option.

Diff Detail

Repository
rP Phabricator
Branch
panel5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22404
Build 30656: Run Core Tests
Build 30655: arc lint + arc unit