Page MenuHomePhabricator

In Differential, give the "moved/copied from" gutter a more clear visual look
ClosedPublic

Authored by epriestley on Feb 20 2019, 12:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 9:47 PM
Unknown Object (File)
Mon, Nov 11, 1:45 PM
Unknown Object (File)
Oct 19 2024, 10:54 AM
Unknown Object (File)
Oct 17 2024, 6:34 PM
Unknown Object (File)
Oct 17 2024, 2:31 AM
Unknown Object (File)
Oct 14 2024, 1:20 AM
Unknown Object (File)
Sep 30 2024, 2:25 PM
Unknown Object (File)
Sep 27 2024, 11:27 PM
Subscribers
None

Details

Summary

Depends on D20196. See PHI985. When empty, the "moved/copied" gutter currently renders with the same background color as the rest of the line. This can be misleading because it makes code look more indented than it is, especially if you're unfamiliar with the tool:

Screen Shot 2019-02-20 at 4.29.15 AM.png (219×187 px, 13 KB)

If we remove this misleading coloration, we get a white gap. This is more clear, but looks a little odd:

Screen Shot 2019-02-20 at 4.29.30 AM.png (275×290 px, 29 KB)

Instead, give this gutter a subtle background fill in all casses, to make it more clear that it's a separate gutter region, not a part of the text diff:

Screen Shot 2019-02-20 at 4.36.25 AM.png (338×269 px, 16 KB)

Test Plan

See screenshots. Copied text from a diff, added/removed inlines, etc.

Diff Detail

Repository
rP Phabricator
Branch
diff3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22081
Build 30162: Run Core Tests
Build 30161: arc lint + arc unit