Convert a manual query against external accounts into a modern Query
ClosedPublic
Actions

Authored by epriestley on Feb 6 2019, 11:13 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T6703: Allow multiple copies of the same auth provider type

Commits

rP8054f7d19156: Convert a manual query against external accounts into a modern Query

Summary

Depends on D20108. Ref T6703. Update this outdated callsite to a more modern appraoch.

Test Plan

Destroyed a user with bin/remove destroy.

Diff Detail

Repository

rP Phabricator

Branch

welcome12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21858
Build 29829: Run Core Tests
Build 29828: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 6 2019, 11:13 PM

Harbormaster completed remote builds in B21858: Diff 48018.Feb 6 2019, 11:14 PM

epriestley requested review of this revision.Feb 6 2019, 11:14 PM

epriestley added a child revision: D20110: Remove the highly suspect "Import from LDAP" workflow.Feb 6 2019, 11:19 PM

amckinley accepted this revision.Feb 7 2019, 6:32 PM

This revision is now accepted and ready to land.Feb 7 2019, 6:32 PM

Closed by commit rP8054f7d19156: Convert a manual query against external accounts into a modern Query (authored by epriestley). · Explain WhyFeb 7 2019, 11:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

7 lines

Diff 48018

View Options

src/applications/people/storage/PhabricatorUser.php

Convert a manual query against external accounts into a modern QueryClosedPublicActions