Page MenuHomePhabricator

Allow users to unlink their last external account with a warning, instead of preventing the action
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:20 PM.
Tags
None
Referenced Files
F14103118: D20106.diff
Tue, Nov 26, 9:01 PM
Unknown Object (File)
Sat, Nov 23, 1:28 PM
Unknown Object (File)
Thu, Nov 21, 8:59 PM
Unknown Object (File)
Sun, Nov 17, 9:41 PM
Unknown Object (File)
Thu, Nov 14, 3:42 AM
Unknown Object (File)
Sun, Nov 10, 5:31 AM
Unknown Object (File)
Sat, Nov 9, 3:27 PM
Unknown Object (File)
Wed, Nov 6, 8:05 AM
Subscribers
None

Details

Summary

Depends on D20105. Fixes T7732. T7732 describes a case where a user had their Google credentials swapped and had trouble regaining access to their account.

Since we now allow email login even if password auth is disabled, it's okay to let users unlink their final account, and it's even reasonable for users to unlink their final account if it is mis-linked.

Just give them a warning that what they're doing is a little sketchy, rather than preventing the workflow.

Test Plan

Unlinked my only login account, got a stern warning instead of a dead end.

Diff Detail

Repository
rP Phabricator
Branch
welcome9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21869
Build 29849: Run Core Tests
Build 29848: arc lint + arc unit