Page MenuHomePhabricator
Differential D20105

In "External Accounts", replace hard-to-find tiny "link" icon with a nice button with text on it
ClosedPublic
Actions

Authored by epriestley on Feb 6 2019, 3:26 PM.
Tags
None
Referenced Files
F14088235: D20105.diff
Sun, Nov 24, 2:12 AM
Unknown Object (File)
Thu, Nov 21, 10:54 PM
Unknown Object (File)
Thu, Nov 21, 10:42 PM
Unknown Object (File)
Wed, Nov 20, 2:33 AM
Unknown Object (File)
Sat, Nov 16, 7:06 AM
Unknown Object (File)
Tue, Nov 12, 3:00 AM
Unknown Object (File)
Sat, Nov 9, 3:26 PM
Unknown Object (File)
Fri, Nov 8, 4:03 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T6703: Allow multiple copies of the same auth provider type
Commits
rPd6f691cf5d5d: In "External Accounts", replace hard-to-find tiny "link" icon with a nice…
Summary

Ref T6703. Replaces the small "link" icon with a more obvious "Link External Account" button.

Moves us toward operating against $config objects instead of against $provider objects, which is more modern and will some day allow us to resolve T6703.

Test Plan

Viewed page, saw a more obvious button. Linked an external account.

Diff Detail

Repository
rP Phabricator
Branch
welcome8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21864
Build 29840: Run Core Tests
Build 29839: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
storage/
9 lines
settings/
panel/
33 lines

Diff 48024

View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php

Loading...
Phabricator · Built by Phacility