Differential D20001

Fix "Welcome Mail" check for a message when no message exists
ClosedPublic
Actions

Authored by epriestley on Jan 20 2019, 2:57 PM.

Details

Reviewers: None
Maniphest Tasks: T13239: null pointer exception in PhabricatorPeopleWelcomeController
Commits: rP491ba6d77e19: (stable) Fix "Welcome Mail" check for a message when no message exists
rPbe8b7c9ebac7: Fix "Welcome Mail" check for a message when no message exists

Summary

Fixes T13239. See that task for discussion.

Test Plan

Tried to send welcome mail with no "Welcome" message.

Diff Detail

Repository

rP Phabricator

Branch

welcome1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21611
Build 29460: Run Core Tests
Build 29459: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 20 2019, 2:57 PM

Harbormaster completed remote builds in B21611: Diff 47756.Jan 20 2019, 2:59 PM

epriestley requested review of this revision.Jan 20 2019, 2:59 PM

epriestley mentioned this in T13239: null pointer exception in PhabricatorPeopleWelcomeController.Jan 20 2019, 3:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2019, 3:00 PM

Closed by commit rPbe8b7c9ebac7: Fix "Welcome Mail" check for a message when no message exists (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

amckinley mentioned this in D19995: Use the customizable "Welcome Mail" message in welcome mail.Jan 21 2019, 7:49 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleWelcomeController.php

2 lines

Diff 47756

View Options

src/applications/people/controller/PhabricatorPeopleWelcomeController.php

Fix "Welcome Mail" check for a message when no message existsClosedPublicActions