Differential D20001

Fix "Welcome Mail" check for a message when no message exists
ClosedPublic
Actions

Authored by epriestley on Jan 20 2019, 2:57 PM.

Tags

None

Referenced Files

	F13150527: D20001.diff
	Sat, May 4, 4:28 PM

	Unknown Object (File)
	Fri, May 3, 2:27 AM

	Unknown Object (File)
	Mon, Apr 29, 1:59 PM

	Unknown Object (File)
	Wed, Apr 24, 10:03 PM

	Unknown Object (File)
	Sun, Apr 21, 4:09 PM

	Unknown Object (File)
	Fri, Apr 19, 5:17 AM

	Unknown Object (File)
	Wed, Apr 17, 3:12 PM

	Unknown Object (File)
	Tue, Apr 16, 5:17 PM

View All 100 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13239: null pointer exception in PhabricatorPeopleWelcomeController
Commits: rP491ba6d77e19: (stable) Fix "Welcome Mail" check for a message when no message exists
rPbe8b7c9ebac7: Fix "Welcome Mail" check for a message when no message exists

Summary

Fixes T13239. See that task for discussion.

Test Plan

Tried to send welcome mail with no "Welcome" message.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 20 2019, 2:57 PM

Harbormaster completed remote builds in B21611: Diff 47756.Jan 20 2019, 2:59 PM

epriestley requested review of this revision.Jan 20 2019, 2:59 PM

epriestley mentioned this in T13239: null pointer exception in PhabricatorPeopleWelcomeController.Jan 20 2019, 3:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2019, 3:00 PM

Closed by commit rPbe8b7c9ebac7: Fix "Welcome Mail" check for a message when no message exists (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

amckinley mentioned this in D19995: Use the customizable "Welcome Mail" message in welcome mail.Jan 21 2019, 7:49 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleWelcomeController.php

2 lines

Diff 47757

src/applications/people/controller/PhabricatorPeopleWelcomeController.php

Loading...