Page MenuHomePhabricator

Convert the "Repository Management" UI to a full-width, Phortune-style UI
ClosedPublic

Authored by epriestley on Nov 21 2018, 7:15 PM.
Tags
None
Referenced Files
F14386895: D19826.diff
Sat, Dec 21, 2:13 PM
F14377107: D19826.id47351.diff
Sat, Dec 21, 12:52 AM
F14369471: D19826.id47351.diff
Fri, Dec 20, 4:51 PM
Unknown Object (File)
Mon, Dec 16, 6:16 PM
Unknown Object (File)
Mon, Dec 16, 6:16 PM
Unknown Object (File)
Mon, Dec 16, 6:16 PM
Unknown Object (File)
Mon, Dec 16, 5:47 PM
Unknown Object (File)
Mon, Dec 16, 4:45 AM
Subscribers
None

Details

Summary

Ref T13216. I want to add some new management options to repositories (e.g., filesize limit, clone timeouts). Before adding new stuff here, update the UI to a full-width, Phortune-style UI.

This partially reverts D18523. About a year ago, several UIs got converted to fixed-width (repository management, config, settings, instance management in SAAS). I didn't think these were good changes and have never really gotten used to them. The rationale wasn't clear to me and these changes just felt like "be more like GitHub". I think usability is significantly worse, e.g. actions are now hidden inside button menus instead of immediately visible.

Phortune also got converted less dramatically to a full-width-with-menu UI, which I like much better. Adjust repository management to use that UI style instead of the fixed-width style.

Test Plan

Screen Shot 2018-11-21 at 11.07.14 AM.png (1×1 px, 198 KB)

Viewed every panel, including the Subversion panel.

Diff Detail

Repository
rP Phabricator
Branch
rconfig1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21200
Build 28827: Run Core Tests
Build 28826: arc lint + arc unit