Make "%LO" and "%LA" more readable when there is only one subclause
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 12:03 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rPHU2ec24ec0d3d2: Make "%LO" and "%LA" more readable when there is only one subclause

Summary

Depends on D19787. Ref T13217. If we only have one subclause, render WHERE (2 > 1) instead of WHERE ((2 > 1)).

When there are two or more clauses, continue to render WHERE ((2 > 1) AND (3 > 2) AND ...).

Test Plan

Looked at query log in DarkConsole, saw more readable queries.

Diff Detail

Repository

rPHU libphutil

Branch

qobject10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21103
Build 28684: Run Core Tests
Build 28683: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 7 2018, 12:03 PM

Harbormaster completed remote builds in B21103: Diff 47254.Nov 7 2018, 12:03 PM

epriestley requested review of this revision.Nov 7 2018, 12:03 PM

For consistency and explicitness, retain one set of parentheses.

Harbormaster completed remote builds in B21104: Diff 47255.Nov 7 2018, 12:07 PM

amckinley accepted this revision.Nov 8 2018, 12:05 AM

This revision is now accepted and ready to land.Nov 8 2018, 12:05 AM

Closed by commit rPHU2ec24ec0d3d2: Make "%LO" and "%LA" more readable when there is only one subclause (authored by epriestley). · Explain WhyNov 13 2018, 4:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

xsprintf/

qsprintf.php

12 lines

Diff 47254

View Options

Make "%LO" and "%LA" more readable when there is only one subclauseClosedPublicActions