Paths

Table of Contentst

Differential D19788

Make "%LO" and "%LA" more readable when there is only one subclause
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 12:03 PM.

Tags

None

Referenced Files

	F18733827: D19788.id.diff
	Tue, Sep 30, 10:42 PM

	F18703901: D19788.diff
	Sun, Sep 28, 5:25 AM

	F18568734: D19788.id47289.diff
	Wed, Sep 10, 12:24 AM

	F18568731: D19788.id47255.diff
	Wed, Sep 10, 12:24 AM

	F18568730: D19788.id47254.diff
	Wed, Sep 10, 12:24 AM

	F18562691: D19788.id47255.diff
	Tue, Sep 9, 4:28 AM

	F18541762: D19788.id.diff
	Sun, Sep 7, 9:34 PM

	F18509918: D19788.id.diff
	Fri, Sep 5, 3:40 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rPHU2ec24ec0d3d2: Make "%LO" and "%LA" more readable when there is only one subclause

Summary

Depends on D19787. Ref T13217. If we only have one subclause, render WHERE (2 > 1) instead of WHERE ((2 > 1)).

When there are two or more clauses, continue to render WHERE ((2 > 1) AND (3 > 2) AND ...).

Test Plan

Looked at query log in DarkConsole, saw more readable queries.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 7 2018, 12:03 PM

Harbormaster completed remote builds in B21103: Diff 47254.Nov 7 2018, 12:03 PM

epriestley requested review of this revision.Nov 7 2018, 12:03 PM

For consistency and explicitness, retain one set of parentheses.

Harbormaster completed remote builds in B21104: Diff 47255.Nov 7 2018, 12:07 PM

amckinley accepted this revision.Nov 8 2018, 12:05 AM

This revision is now accepted and ready to land.Nov 8 2018, 12:05 AM

Closed by commit rPHU2ec24ec0d3d2: Make "%LO" and "%LA" more readable when there is only one subclause (authored by epriestley). · Explain WhyNov 13 2018, 4:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

xsprintf/

qsprintf.php

12 lines

Diff 47289

View Options

Make "%LO" and "%LA" more readable when there is only one subclauseClosedPublicActions