Page MenuHomePhabricator

Make %LO, %LA, %LQ and %LJ more lax in what they accept (warnings instead of exceptions)
ClosedPublic

Authored by epriestley on Nov 7 2018, 11:59 AM.
Tags
None
Referenced Files
F18805424: D19787.id47288.diff
Sat, Oct 18, 3:12 PM
F18769092: D19787.id.diff
Wed, Oct 8, 6:28 AM
F18745355: D19787.id47253.diff
Fri, Oct 3, 6:21 AM
F18739722: D19787.diff
Wed, Oct 1, 10:37 PM
F18733826: D19787.id.diff
Tue, Sep 30, 10:42 PM
F18669783: D19787.diff
Sep 24 2025, 9:55 PM
F18568728: D19787.id47288.diff
Sep 10 2025, 12:24 AM
F18568724: D19787.id47253.diff
Sep 10 2025, 12:23 AM
Subscribers
None

Details

Summary

Depends on D19786. Ref T13217. I had imagined making these new conversions strict, but a lot of stuff breaks when we do because they make sense to use in base classes like CursorPagedPolicyAwareQuery, and it's hard to completely fix all the downstream classes in one fell swoop.

Instead, let them warn for now (like %Q) and we can make them stricter in a future change.

Test Plan

In Phabricator, saw warnings instead of immediate fatals when strings are passed to these conversions.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable