Page MenuHomePhabricator

Make %LO, %LA, %LQ and %LJ more lax in what they accept (warnings instead of exceptions)
ClosedPublic

Authored by epriestley on Nov 7 2018, 11:59 AM.
Tags
None
Referenced Files
F18111010: D19787.id47288.diff
Tue, Aug 12, 4:38 AM
F18095196: D19787.diff
Thu, Aug 7, 10:33 PM
F17959264: D19787.id.diff
Fri, Aug 1, 8:02 AM
F17947987: D19787.diff
Thu, Jul 31, 7:44 PM
F17809779: D19787.id.diff
Jul 25 2025, 5:03 PM
Unknown Object (File)
Jun 26 2025, 6:36 PM
Unknown Object (File)
Jun 17 2025, 2:25 AM
Unknown Object (File)
Jun 3 2025, 4:18 AM
Subscribers
None

Details

Summary

Depends on D19786. Ref T13217. I had imagined making these new conversions strict, but a lot of stuff breaks when we do because they make sense to use in base classes like CursorPagedPolicyAwareQuery, and it's hard to completely fix all the downstream classes in one fell swoop.

Instead, let them warn for now (like %Q) and we can make them stricter in a future change.

Test Plan

In Phabricator, saw warnings instead of immediate fatals when strings are passed to these conversions.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable