Page MenuHomePhabricator

Make %LO, %LA, %LQ and %LJ more lax in what they accept (warnings instead of exceptions)

Authored by epriestley on Nov 7 2018, 11:59 AM.



Depends on D19786. Ref T13217. I had imagined making these new conversions strict, but a lot of stuff breaks when we do because they make sense to use in base classes like CursorPagedPolicyAwareQuery, and it's hard to completely fix all the downstream classes in one fell swoop.

Instead, let them warn for now (like %Q) and we can make them stricter in a future change.

Test Plan

In Phabricator, saw warnings instead of immediate fatals when strings are passed to these conversions.

Diff Detail

rPHU libphutil
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 7 2018, 11:59 AM
epriestley requested review of this revision.Nov 7 2018, 12:00 PM
amckinley accepted this revision.Nov 8 2018, 12:04 AM
This revision is now accepted and ready to land.Nov 8 2018, 12:04 AM
This revision was automatically updated to reflect the committed changes.