Page MenuHomePhabricator

Make "%LO" and "%LA" more readable when there is only one subclause
ClosedPublic

Authored by epriestley on Nov 7 2018, 12:03 PM.

Details

Summary

Depends on D19787. Ref T13217. If we only have one subclause, render WHERE (2 > 1) instead of WHERE ((2 > 1)).

When there are two or more clauses, continue to render WHERE ((2 > 1) AND (3 > 2) AND ...).

Test Plan

Looked at query log in DarkConsole, saw more readable queries.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 7 2018, 12:03 PM
epriestley requested review of this revision.Nov 7 2018, 12:03 PM
epriestley updated this revision to Diff 47255.Nov 7 2018, 12:06 PM
epriestley edited the summary of this revision. (Show Details)
  • For consistency and explicitness, retain one set of parentheses.
amckinley accepted this revision.Nov 8 2018, 12:05 AM
This revision is now accepted and ready to land.Nov 8 2018, 12:05 AM
This revision was automatically updated to reflect the committed changes.