Page MenuHomePhabricator
Differential D19786

Add %LJ (joined with spaces) to qsprintf() for merging JOIN clauses
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 10:48 AM.
Tags
None
Referenced Files
F15471535: D19786.id47287.diff
Sat, Apr 5, 5:48 AM
F15470375: D19786.id.diff
Fri, Apr 4, 9:42 PM
F15470374: D19786.id47252.diff
Fri, Apr 4, 9:42 PM
F15459324: D19786.diff
Mon, Mar 31, 11:56 AM
F15444544: D19786.diff
Thu, Mar 27, 10:00 AM
F15435606: D19786.id.diff
Tue, Mar 25, 9:13 AM
F15432752: D19786.id47252.diff
Mon, Mar 24, 7:35 PM
F15432707: D19786.diff
Mon, Mar 24, 7:30 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13217: Upgrading: Hardening of qsprintf()
Commits
rPHU3c1f820b6356: Add %LJ (joined with spaces) to qsprintf() for merging JOIN clauses
Summary

Depends on D19783. Ref T13217. Beyond AND, OR, and comma, we also need spaces to join JOIN clauses. Add %LJ, like the other query sublist conversions.

Test Plan

See upcoming changes.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
xsprintf/
12 lines

Diff 47287

View Options

src/xsprintf/qsprintf.php

Loading...
Phabricator · Built by Phacility