Page MenuHomePhabricator

Support (basic) commenting on Phriction documents
ClosedPublic

Authored by epriestley on Sep 11 2018, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:07 PM
Unknown Object (File)
Feb 12 2024, 5:02 AM
Unknown Object (File)
Feb 11 2024, 6:03 AM
Unknown Object (File)
Jan 30 2024, 12:48 AM
Unknown Object (File)
Jan 23 2024, 3:36 PM
Unknown Object (File)
Jan 22 2024, 12:11 AM
Unknown Object (File)
Jan 4 2024, 5:24 PM
Unknown Object (File)
Dec 31 2023, 8:02 PM
Subscribers
None

Details

Summary

Depends on D19659. Fixes T1894. Ref T13077. See PHI840.

  • Add an EditEngine, although it currently supports no fields.
  • Add (basic, top-level-only) commenting (we already had the table in the database).

This will probably create some issues. I'm most concerned about documents accumulating a ton of old, irrelevant comments over time which are hard to keep track of and no longer relevant. But I think this is probably a step forward in almost all cases, and a good thing on the balance.

This also moves us incrementally toward putting all editing on top of EditEngine.

Test Plan

Screen Shot 2018-09-11 at 8.35.27 AM.png (1×2 px, 169 KB)

Diff Detail

Repository
rP Phabricator
Branch
wiki2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20790
Build 28274: Run Core Tests
Build 28273: arc lint + arc unit