Page MenuHomePhabricator

Give Phriction documents a normal timeline
ClosedPublic

Authored by epriestley on Sep 11 2018, 3:15 PM.

Details

Summary

Ref T13077. See PHI840. Ref T1894. I'm planning to just let you comment on Phriction documents. I think this will create a few problems (e.g., around popular documents which collect long comment threads that are eventually obsolete) but nothing should be too terribly critical (e.g., we handle it gracefully when objects have very large number of comments/transactions) and for most documents this is likely just a net improvement.

"Just enable comments" is probably not the final iteration on this, but I think it's probably a step forward on the balance, not a step sideways or a slippery slope down into a dark hole or anything.

Test Plan

Diff Detail

Repository
rP Phabricator
Branch
wiki1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 20789
Build 28272: Run Core Tests
Build 28271: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 11 2018, 3:15 PM
epriestley requested review of this revision.Sep 11 2018, 3:16 PM
amckinley accepted this revision.Sep 11 2018, 7:23 PM
This revision is now accepted and ready to land.Sep 11 2018, 7:23 PM
This revision was automatically updated to reflect the committed changes.