Page MenuHomePhabricator

Support an "Ancestors Of: ..." constraint in commit queries
ClosedPublic

Authored by epriestley on May 7 2018, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:54 PM
Unknown Object (File)
Mon, Dec 2, 8:09 PM
Unknown Object (File)
Mon, Dec 2, 8:09 PM
Unknown Object (File)
Mon, Dec 2, 8:09 PM
Unknown Object (File)
Mon, Dec 2, 8:09 PM
Unknown Object (File)
Mon, Dec 2, 8:09 PM
Unknown Object (File)
Wed, Nov 27, 2:13 PM
Unknown Object (File)
Tue, Nov 26, 12:58 PM
Subscribers
None

Details

Summary

Ref T13137. See PHI609. An install would like to filter audit requests on a particular branch, e.g. "master".

This is difficult in the general case because we can not apply this constraint efficiently under every conceivable data shape, but we can do a reasonable job in most practical cases.

See T13137#238822 for more detailed discussion on the approach here.

This is a bit rough, but should do the job for now.

Test Plan
  • Filtered commits by various branches, e.g. "master"; "lfs". Saw correct-seeming results.
  • Stubbed out the "just list everything" path to hit the diffusion.internal.ancestors path, saw the same correct-seeming results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/diffusion/query/DiffusionCommitQuery.php
320

"is has"

This revision is now accepted and ready to land.May 7 2018, 11:24 PM
This revision was automatically updated to reflect the committed changes.