Page MenuHomePhabricator

Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
ClosedPublic

Authored by epriestley on Feb 12 2018, 8:11 PM.
Tags
None
Referenced Files
F15591963: D19066.diff
Sat, May 10, 3:35 AM
F15588769: D19066.diff
Fri, May 9, 9:24 AM
F15585238: D19066.id45707.diff
Thu, May 8, 7:40 AM
F15539208: D19066.id45702.diff
Fri, Apr 25, 12:09 AM
F15529701: D19066.id.diff
Tue, Apr 22, 9:49 PM
F15525024: D19066.diff
Mon, Apr 21, 11:51 AM
F15430777: D19066.diff
Mar 24 2025, 8:52 AM
F15388628: D19066.id.diff
Mar 15 2025, 4:08 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19065. Ref T13054. Instead of just updating containerPHID and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) withContainerPHIDs() when loading active diffs for a revision.

Test Plan
  • Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
  • With daemons, saw builds actually build and get the right container PHID.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 8:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.