Paths

Table of Contentst

Differential D19066

Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
ClosedPublic
Actions

Authored by epriestley on Feb 12 2018, 8:11 PM.

Tags

None

Referenced Files

	F13850688: D19066.diff
	Sat, Sep 28, 10:28 PM

	Unknown Object (File)
	Sat, Sep 14, 4:38 PM

	Unknown Object (File)
	Fri, Sep 6, 2:18 AM

	Unknown Object (File)
	Fri, Sep 6, 2:18 AM

	Unknown Object (File)
	Fri, Sep 6, 2:18 AM

	Unknown Object (File)
	Mon, Sep 2, 2:47 PM

	Unknown Object (File)
	Mon, Sep 2, 6:53 AM

	Unknown Object (File)
	Sun, Sep 1, 10:30 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits: rP6f508a225869: Update buildable containerPHIDs in a proper way via BuildWorker rather than via…

Summary

Depends on D19065. Ref T13054. Instead of just updating containerPHID and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) withContainerPHIDs() when loading active diffs for a revision.

Test Plan

Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
With daemons, saw builds actually build and get the right container PHID.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2018, 8:11 PM

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 8:11 PM

Harbormaster completed remote builds in B19505: Diff 45702.Feb 12 2018, 8:12 PM

epriestley requested review of this revision.Feb 12 2018, 8:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 8:18 PM

Closed by commit rP6f508a225869: Update buildable containerPHIDs in a proper way via BuildWorker rather than via… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

31 lines

storage/

DifferentialRevision.php

3 lines

harbormaster/

engine/

HarbormasterBuildEngine.php

19 lines

HarbormasterMessageType.php

1 line

Diff 45707

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...

src/applications/harbormaster/engine/HarbormasterMessageType.php

Loading...