Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
F13135549: D18940.diff
Thu, May 2, 9:30 AM
Unknown Object (File)
Sun, Apr 28, 2:59 AM
Unknown Object (File)
Wed, Apr 24, 10:09 PM
Unknown Object (File)
Sun, Apr 21, 4:20 PM
Unknown Object (File)
Fri, Apr 19, 7:12 PM
Unknown Object (File)
Fri, Apr 5, 10:18 AM
Unknown Object (File)
Apr 2 2024, 8:42 AM
Unknown Object (File)
Feb 26 2024, 9:52 PM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Branch
symbol4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19196
Build 25932: Run Core Tests
Build 25931: arc lint + arc unit