Page MenuHomePhabricator

Fix an issue with symbol lookup identifying path names in Diffusion
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:45 PM.
Tags
None
Referenced Files
F15378933: D18940.diff
Thu, Mar 13, 5:42 PM
F15367621: D18940.diff
Tue, Mar 11, 8:06 PM
Unknown Object (File)
Mon, Feb 17, 1:52 AM
Unknown Object (File)
Feb 9 2025, 5:04 AM
Unknown Object (File)
Feb 9 2025, 5:04 AM
Unknown Object (File)
Feb 9 2025, 5:04 AM
Unknown Object (File)
Jan 30 2025, 8:54 AM
Unknown Object (File)
Jan 24 2025, 11:20 PM
Subscribers
None

Details

Summary

Depends on D18939. Ref T13047. Symbol lookup can be activated from a diff (in Differential or Diffusion) or from the static view of a file at a particular commit.

In the latter case, we need to figure out the path a little differently. The character and line number approaches still work as written.

Test Plan
  • Command-clicked symbols in the Diffusion browse view with blame on and off; saw path, line and char populate properly.
  • Command-clicked symbols in Differential diff view to check I didn't break anything.

Diff Detail

Repository
rP Phabricator
Branch
symbol4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19196
Build 25932: Run Core Tests
Build 25931: arc lint + arc unit