Page MenuHomePhabricator

When available, pass path, line and repository hints to external symbol queries
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 7:01 AM
Unknown Object (File)
Sun, Nov 24, 6:50 AM
Unknown Object (File)
Tue, Nov 19, 10:17 PM
Unknown Object (File)
Fri, Nov 15, 6:00 PM
Unknown Object (File)
Tue, Nov 12, 4:31 AM
Unknown Object (File)
Sat, Nov 9, 2:56 PM
Unknown Object (File)
Fri, Nov 8, 2:02 PM
Unknown Object (File)
Fri, Nov 8, 7:54 AM
Subscribers
None

Details

Summary

Depends on D18936. Ref T13047. Third parties can define external symbol sources that let users jump to PHP or Python documentation or query some server.

Give these queries more information so they can try to get better results: the path and line where the symbol appeared, and any known repository scope.

Test Plan

Wrote a fake external source that used this data, command-clicked a symbol in Differential, saw a fake external symbol result.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable