Use the configured viewer more consistently in the Herald commit adapter
d8f51dff6ec3
Actions

Description

Use the configured viewer more consistently in the Herald commit adapter

Summary: See PHI276. Ref T13048. The fix in D18933 got one callsite, but missed the one in the callConduit() method, so the issue isn't fully fixed in production. Convert this adapter to use a real viewer (if one is available) more thoroughly.

Test Plan: Ran rules in test console, saw field values. Will test in production again.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048

Differential Revision: https://secure.phabricator.com/D18950

Details

Provenance

epriestley	Authored on Jan 29 2018, 1:49 AM
epriestley	Pushed on Jan 29 2018, 11:00 PM

Reviewer

amckinley

Differential Revision

D18950: Use the configured viewer more consistently in the Herald commit adapter

Parents

rP98402b885b62: Add a bit of test coverage for bulky vs compact edge data representations

Branches

Unknown

Tags

Unknown

Tasks

T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald

Build Status

Buildable 19256
Build 26023: Run Core Tests

Event Timeline

epriestley committed rPd8f51dff6ec3: Use the configured viewer more consistently in the Herald commit adapter (authored by epriestley).Jan 29 2018, 11:00 PM

epriestley added a task: T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald.

Harbormaster completed building B19256: rPd8f51dff6ec3: Use the configured viewer more consistently in the Herald commit adapter.Jan 29 2018, 11:01 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

herald/

HeraldCommitAdapter.php

rPd8f51dff6ec3

View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php