Page MenuHomePhabricator

Mark the "Reviewer" field for Commits as deprecated
ClosedPublic

Authored by epriestley on Jan 25 2018, 6:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 11:19 PM
Unknown Object (File)
Apr 30 2025, 1:03 AM
Unknown Object (File)
Apr 29 2025, 5:38 AM
Unknown Object (File)
Apr 23 2025, 3:59 PM
Unknown Object (File)
Apr 22 2025, 9:23 PM
Unknown Object (File)
Apr 18 2025, 7:53 PM
Unknown Object (File)
Apr 17 2025, 9:46 PM
Unknown Object (File)
Mar 28 2025, 9:54 PM
Subscribers
None

Details

Summary

Depends on D18931. Ref T13048. Ref T13041. This field means "the first accepting reviewer, where order is mostly arbitrary". Modern rules should almost certainly use "Accepting Reviewers" instead.

Getting rid of this completely is a pain, but we can at least reduce confusion by marking it as not-the-new-hotness. Add a "Deprecated" group, move it there, and mark it for exile.

Test Plan

Edited a commit rule, saw it in "Deprecated" group at the bottom of the list:

Screen Shot 2018-01-25 at 10.25.41 AM.png (772×403 px, 88 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19183
Build 25909: Run Core Tests
Build 25908: arc lint + arc unit