Page MenuHomePhabricator

Mark the "Reviewer" field for Commits as deprecated
ClosedPublic

Authored by epriestley on Jan 25 2018, 6:28 PM.
Tags
None
Referenced Files
F18745383: D18932.diff
Fri, Oct 3, 6:29 AM
F18744181: D18932.id45425.diff
Fri, Oct 3, 2:07 AM
F18653162: D18932.diff
Sun, Sep 21, 11:25 AM
F18649995: D18932.diff
Sat, Sep 20, 11:01 PM
F18623578: D18932.diff
Mon, Sep 15, 4:28 PM
F18591783: D18932.id.diff
Fri, Sep 12, 10:06 AM
F18590577: D18932.id45402.diff
Fri, Sep 12, 6:28 AM
F18590576: D18932.id45425.diff
Fri, Sep 12, 6:28 AM
Subscribers
None

Details

Summary

Depends on D18931. Ref T13048. Ref T13041. This field means "the first accepting reviewer, where order is mostly arbitrary". Modern rules should almost certainly use "Accepting Reviewers" instead.

Getting rid of this completely is a pain, but we can at least reduce confusion by marking it as not-the-new-hotness. Add a "Deprecated" group, move it there, and mark it for exile.

Test Plan

Edited a commit rule, saw it in "Deprecated" group at the bottom of the list:

Screen Shot 2018-01-25 at 10.25.41 AM.png (772×403 px, 88 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19183
Build 25909: Run Core Tests
Build 25908: arc lint + arc unit