Add drydock.blueprint.edit Conduit method
ClosedPublic
Actions

Authored by timhirsh on Dec 8 2017, 4:31 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP60e5c0ec1b3e: Add drydock.blueprint.edit Conduit method

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Ref: https://admin.phacility.com/PHI243

Since our use case primarily focuses on transaction editing, this patch implements the drydock.blueprint.edit api method with the understanding that:
a) this is a work in progress
b) object editing is supported, but object creation is not yet implemented

Test Plan

updated existing blueprints via Conduit UI
regression tested maniphest.edit by creating new and updating existing tasks

Diff Detail

Repository

rP Phabricator

Branch

PHI243_drydock_blueprint_edit_api_method

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18936
Build 25536: Run Core Tests
Build 25535: arc lint + arc unit

Event Timeline

timhirsh created this revision.Dec 8 2017, 4:31 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 8 2017, 4:31 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: yelirekim. · View Herald Transcript

Harbormaster completed remote builds in B18936: Diff 45163.Dec 8 2017, 4:33 PM

timhirsh requested review of this revision.Dec 8 2017, 4:33 PM

Looks great, thanks! I added you to Blessed Committers so you should be able to arc land this yourself -- check the project description for some instructions, or yell if you run into issues.

This revision is now accepted and ready to land.Dec 8 2017, 4:45 PM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 8 2017, 4:45 PM

Closed by commit rP60e5c0ec1b3e: Add drydock.blueprint.edit Conduit method (authored by timhirsh). · Explain WhyDec 8 2017, 4:55 PM

This revision was automatically updated to reflect the committed changes.

Awesome, thanks!

epriestley mentioned this in D18845: Modularize transactions for Drydock Blueprints.Dec 26 2017, 5:44 PM

epriestley mentioned this in D18849: Allow "drydock.blueprint.edit" to create blueprints.Dec 26 2017, 6:24 PM

epriestley mentioned this in rP83c528c46435: Modularize transactions for Drydock Blueprints.Jan 4 2018, 6:03 PM

epriestley mentioned this in rPf3f1f9dc577a: Allow "drydock.blueprint.edit" to create blueprints.Jan 4 2018, 6:08 PM

epriestley mentioned this in T13650: Unhandled Exception accessing Conduit's dashboard.panel.edit: "Attempting to use a panel in a way that requires an implementation, but the panel implementation ("") is unknown to Phabricator.".Jun 1 2021, 6:49 AM