Page MenuHomePhabricator

Fix inbound mail handling for messages with no HTML body part
ClosedPublic

Authored by epriestley on Nov 22 2017, 3:45 PM.
Tags
None
Referenced Files
F12608969: D18778.diff
Tue, Mar 19, 2:04 AM
Unknown Object (File)
Feb 3 2024, 5:08 PM
Unknown Object (File)
Jan 23 2024, 2:00 PM
Unknown Object (File)
Jan 13 2024, 6:48 AM
Unknown Object (File)
Jan 11 2024, 12:16 PM
Unknown Object (File)
Dec 21 2023, 10:31 PM
Unknown Object (File)
Dec 21 2023, 10:31 PM
Unknown Object (File)
Dec 21 2023, 10:31 PM
Subscribers
None
Tokens
"Love" token, awarded by catalindazoot.

Details

Summary

See D18776. See https://discourse.phabricator-community.org/t/cant-create-maniphest-tasks-by-email/754/2.

The change in D18776 to improve handling of non-utf8 HTML parts broke handling of mail with no HTML parts. Partly, this is because MimeMailParser has a "traditional" PHP-style API where the return type is an exciting surprise.

Test Plan
  • Sent a text-only message in Mail.app.
  • Used "Show Raw" to copy it to mail.txt, verifying that the raw message contains ONLY a text body.
  • Ran cat mail.txt | ./scripts/mail/mail_handler.php --trace --process-duplicates.
    • Before patch: error about bad idx() on a non-array.
    • After patch: clean mail processing.
  • Did the same with a message with both HTML and text bodies to make sure I didn't break anything.

Ideally we'd probably get test coverage on this, but it's been touched roughly once a year since 2013 so it'll probably hold.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable