Page MenuHomePhabricator
Differential D17422

Add a lipsum generator for Badges
ClosedPublic
Actions

Authored by epriestley on Feb 27 2017, 1:18 PM.
Tags
None
Referenced Files
F13085895: D17422.diff
Wed, Apr 24, 11:58 PM
Unknown Object (File)
Thu, Apr 11, 8:16 AM
Unknown Object (File)
Tue, Apr 9, 10:14 AM
Unknown Object (File)
Mon, Apr 8, 4:57 AM
Unknown Object (File)
Sun, Mar 31, 12:04 AM
Unknown Object (File)
Thu, Mar 28, 6:52 AM
Unknown Object (File)
Mar 19 2024, 6:07 PM
Unknown Object (File)
Mar 15 2024, 10:25 PM
View All Files
Subscribers
cspeckmim

Details

Reviewers
chad
Maniphest Tasks
T12270: Unbeta Badges
T12319: Investigate an Owners-related performance issue on revision detail pages
Commits
rP5cb4c76bef6b: Add a lipsum generator for Badges
Summary

Ref T12319. Ref T12270. Allow badges to be generated with bin/lipsum. These aren't hugely sophisticated but I'm not sure about the fate of T9010 yet or what's happening with the quality levels, and didn't want to make those changes more difficult.

Test Plan
  • Used bin/lipsum generate badges --force --quickly to generate badges.
  • Made some coffee and came back to 20K badges.

Screen Shot 2017-02-27 at 4.59.13 AM.png (1×2 px, 305 KB)

Diff Detail

Repository
rP Phabricator
Branch
lipsum4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15792
Build 20882: Run Core Tests
Build 20881: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2017, 1:18 PM
Harbormaster completed remote builds in B15792: Diff 41891.Feb 27 2017, 1:19 PM
cspeckmim added a subscriber: cspeckmim.Feb 27 2017, 2:00 PM

diablo.gif (480×640 px, 185 KB)

epriestley added a comment.Feb 27 2017, 2:56 PM

I was using this source if anyone wants to send the affixes so we can generate Obsidian Ring of the Zodiac:

http://diablo.gamepedia.com/Affixes_(Diablo_I)

chad accepted this revision.Feb 27 2017, 3:43 PM
This revision is now accepted and ready to land.Feb 27 2017, 3:43 PM
epriestley mentioned this in T12270: Unbeta Badges.Feb 27 2017, 4:10 PM
Closed by commit rP5cb4c76bef6b: Add a lipsum generator for Badges (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2017, 5:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41891

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php

Loading...
View Options

src/applications/badges/lipsum/PhabricatorBadgesLootContextFreeGrammar.php

Loading...
Phabricator · Built by Phacility