Always parse the first line of a commit message as a title
ClosedPublic
Actions

Authored by epriestley on Jan 1 2017, 4:30 PM.

Details

Reviewers

Maniphest Tasks

T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:"

Commits

rP81e2a1cf6b22: Always parse the first line of a commit message as a title

Summary

Fixes T10312. If your first line is "Reviewers: xyz", it's a title, not a "Reviewers" field.

Test Plan

Added unit test.

Diff Detail

Repository

rP Phabricator

Branch

parse2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15067
Build 19773: Run Core Tests
Build 19772: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 1 2017, 4:30 PM

epriestley added inline comments.Jan 1 2017, 4:48 PM

src/applications/differential/parser/DifferentialCommitMessageParser.php
179	This is for T6050, I'll provide some context there.

epriestley mentioned this in T6050: Improve error message / UX when fields are specified twice in revision information.Jan 1 2017, 4:54 PM

chad accepted this revision.Jan 1 2017, 5:31 PM

This revision is now accepted and ready to land.Jan 1 2017, 5:31 PM

Closed by commit rP81e2a1cf6b22: Always parse the first line of a commit message as a title (authored by epriestley, committed by epriestley). · Explain WhyJan 1 2017, 5:56 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12069: `arc diff --reviewers` inserts reviewers twice..Jan 5 2017, 9:56 PM

epriestley mentioned this in D17147: Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title".Jan 5 2017, 10:00 PM

epriestley mentioned this in rARCade25facfdf2: Fix a bad interaction between "arc diff --reviewers" and "the first line of a….Jan 5 2017, 10:35 PM

epriestley mentioned this in T12119: `arc diff --reviewers foo` puts reviewers into Summary field.Jan 18 2017, 5:31 PM

epriestley mentioned this in T12197: Audits are no longer triggered using singular "Auditor:".Feb 3 2017, 12:23 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialCommitMessageParser.php

28 lines

__tests__/

messages/

title-with-label.txt

11 lines

Diff 41179

View Options

src/applications/differential/parser/DifferentialCommitMessageParser.php

View Options

src/applications/differential/parser/tests/messages/title-with-label.txt

Always parse the first line of a commit message as a titleClosedPublicActions