Diffusion Phabricator 81e2a1cf6b22

Always parse the first line of a commit message as a title
81e2a1cf6b22
Actions

Description

Always parse the first line of a commit message as a title

Summary: Fixes T10312. If your first line is "Reviewers: xyz", it's a title, not a "Reviewers" field.

Test Plan: Added unit test.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10312

Differential Revision: https://secure.phabricator.com/D17122

Details

Provenance

epriestley	Authored on Jan 1 2017, 4:23 PM
epriestley	Pushed on Jan 1 2017, 5:56 PM

Reviewer

chad

Differential Revision

D17122: Always parse the first line of a commit message as a title

Parents

rPab17a7d4bf84: Be more lenient when accepting "Differential Revision" in the presence of…

Branches

Unknown

Tags

Unknown

Tasks

T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:"

Build Status

Buildable 15073
Build 19782: Run Core Tests

Event Timeline

epriestley committed rP81e2a1cf6b22: Always parse the first line of a commit message as a title (authored by epriestley).Jan 1 2017, 5:56 PM

epriestley added a task: T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:".

Harbormaster completed building B15073: rP81e2a1cf6b22: Always parse the first line of a commit message as a title.Jan 1 2017, 5:58 PM

Changes (2)

Path

Size

src/

applications/

differential/

parser/

DifferentialCommitMessageParser.php

__tests__/

messages/

title-with-label.txt

rP81e2a1cf6b22

View Options

src/applications/differential/parser/DifferentialCommitMessageParser.php