Page MenuHomePhabricator

Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"

Authored by epriestley on Jun 22 2016, 5:36 PM.



Ref T11179. This splits "Edit Blocking Tasks" into two options now that we have more room ("Edit Parent Tasks", "Edit Subtasks").

This also renames "Blocking" tasks to "Subtasks", and "Blocked" tasks to "Parent" tasks. My goals here are:

  • Make the relationship direction more clear: it's more clear which way is up with "parent" and "subtask" at a glance than with "blocking" and "blocked" or "dependent" and "dependency".
  • Align language with "Create Subtask".
  • To some small degree, use more flexible/general-purpose language, although I haven't seen any real confusion here.

Fixes T6815. I think I narrowed this down to two issues:

  • Just throwing a bare exeception (we now return a dialog explicitly).
  • Not killing open transactions when the cyclec check fails (we now kill them).
Test Plan
  • Edited parent tasks.
  • Edited subtasks.
  • Tried to introduce graph cycles, got a nice error dialog.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38884.Jun 22 2016, 5:36 PM
epriestley retitled this revision from to Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley planned changes to this revision.Jun 22 2016, 5:41 PM

Those tests are likely me, let me look at 'em.

(I don't love these icons but didn't immediately see anything better.)

epriestley updated this revision to Diff 38885.Jun 22 2016, 5:43 PM
  • Fix tests by moving an existing transaction kill up a level.

I think I got all the "blocking / blocked" language except Maniphest search filters, but those have some outstanding bugs (T8126, some others?) so I figured I'd wait until I resolve those to sort them out.

chad accepted this revision.Jun 22 2016, 6:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 6:10 PM
This revision was automatically updated to reflect the committed changes.