Page MenuHomePhabricator

Make all table entries clickable
Needs ReviewPublic

Authored by jasonfsmitty on Oct 23 2015, 1:20 PM.
This revision needs review, but there are no reviewers specified.

Details

Summary

Ref T9620. Every non-empty table entry has a link to a filtered search for those specific tickets

Test Plan

Tested on our internal Phabricator instance.

Diff Detail

Repository
rP Phabricator
Branch
T9620
Lint
Lint OK
Unit
Unit Test Errors
Build Status
Buildable 8539
Build 9855: arc lint + arc unit

Event Timeline

jasonfsmitty retitled this revision from to Ref T9620: make all table entries clickable..
jasonfsmitty updated this object.
jasonfsmitty edited the test plan for this revision. (Show Details)
jasonfsmitty added a reviewer: epriestley.
jasonfsmitty added a subscriber: jasonfsmitty.
epriestley requested changes to this revision.Nov 2 2015, 4:40 PM
epriestley edited edge metadata.

I don't want to bring any changes to "Reports" usptream; it's basically frozen until it is replaced by Facts (T1562).

src/applications/maniphest/controller/ManiphestReportController.php
569

This is unused, and this approach won't scale for large numbers of tasks.

This revision now requires changes to proceed.Nov 2 2015, 4:40 PM
jasonfsmitty edited edge metadata.
  • Remove used line of code

I don't want to bring any changes to "Reports" usptream; it's basically frozen until it is replaced by Facts (T1562).

Understood, thanks for the feedback!

I opened T9689 for the unit test failures, which appeared to be an issue with having auth.email-domains configured.

joshuaspence retitled this revision from Ref T9620: make all table entries clickable. to Make all table entries clickable.Nov 13 2015, 9:54 AM
joshuaspence updated this object.