Page MenuHomePhabricator
Differential D14318

Make all table entries clickable
Needs ReviewPublic
Actions

Authored by jasonfsmitty on Oct 23 2015, 1:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 11:38 PM
Unknown Object (File)
Sun, Dec 8, 11:38 PM
Unknown Object (File)
Sun, Dec 8, 11:38 PM
Unknown Object (File)
Sun, Dec 8, 11:37 PM
Unknown Object (File)
Tue, Dec 3, 7:57 PM
Unknown Object (File)
Tue, Dec 3, 7:57 PM
Unknown Object (File)
Tue, Dec 3, 7:57 PM
Unknown Object (File)
Tue, Dec 3, 7:46 PM
View All Files
Subscribers
jasonfsmitty
joshuaspence
Korvin
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T9620: Every entry in the Maniphest Report table should be clickable
Summary

Ref T9620. Every non-empty table entry has a link to a filtered search for those specific tickets

Test Plan

Tested on our internal Phabricator instance.

Diff Detail

Repository
rP Phabricator
Branch
T9620
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8539
Build 9855: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
4 msManiphestTaskTestCase::Unknown Unit Message ("")
0 msManiphestTaskTestCase::Unknown Unit Message ("")
6,784 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
6 msPhabricatorConduitTestCase::Unknown Unit Message ("")
0 msPhabricatorInfrastructureTestCase::Unknown Unit Message ("")
View Full Test Results (2 Failed · 7 Passed)

Event Timeline

jasonfsmitty updated this revision to Diff 34568.Oct 23 2015, 1:20 PM
jasonfsmitty added a task: T9620: Every entry in the Maniphest Report table should be clickable.
jasonfsmitty retitled this revision from to Ref T9620: make all table entries clickable..
jasonfsmitty updated this object.
jasonfsmitty edited the test plan for this revision. (Show Details)
jasonfsmitty added a reviewer: epriestley.
jasonfsmitty added a subscriber: jasonfsmitty.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 23 2015, 1:20 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley requested changes to this revision.Nov 2 2015, 4:40 PM
epriestley edited edge metadata.

I don't want to bring any changes to "Reports" usptream; it's basically frozen until it is replaced by Facts (T1562).

src/applications/maniphest/controller/ManiphestReportController.php
569

This is unused, and this approach won't scale for large numbers of tasks.

This revision now requires changes to proceed.Nov 2 2015, 4:40 PM
jasonfsmitty updated this revision to Diff 34729.Nov 2 2015, 5:51 PM
jasonfsmitty edited edge metadata.
  • Remove used line of code
jasonfsmitty added a comment.Nov 2 2015, 5:57 PM
In D14318#160427, @epriestley wrote:

I don't want to bring any changes to "Reports" usptream; it's basically frozen until it is replaced by Facts (T1562).

Understood, thanks for the feedback!

jasonfsmitty mentioned this in T9689: unit test failure when auth.email-domains is configured.Nov 2 2015, 6:06 PM

I opened T9689 for the unit test failures, which appeared to be an issue with having auth.email-domains configured.

epriestley removed reviewers: epriestley, Blessed Reviewers.Nov 5 2015, 3:22 PM
joshuaspence added a subscriber: joshuaspence.Nov 13 2015, 9:39 AM
joshuaspence retitled this revision from Ref T9620: make all table entries clickable. to Make all table entries clickable.Nov 13 2015, 9:54 AM
joshuaspence updated this object.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
64 lines

Diff 34729

View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
Phabricator · Built by Phacility