Differential D14318

Make all table entries clickable
Needs ReviewPublic
Actions

Authored by jasonfsmitty on Oct 23 2015, 1:20 PM.

Details

Reviewers: None
Maniphest Tasks: T9620: Every entry in the Maniphest Report table should be clickable

Summary

Ref T9620. Every non-empty table entry has a link to a filtered search for those specific tickets

Test Plan

Tested on our internal Phabricator instance.

Diff Detail

Repository

rP Phabricator

Branch

T9620

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8378
Build 9617: arc lint + arc unit

Event Timeline

jasonfsmitty updated this revision to Diff 34568.Oct 23 2015, 1:20 PM

jasonfsmitty added a task: T9620: Every entry in the Maniphest Report table should be clickable.

jasonfsmitty retitled this revision from to Ref T9620: make all table entries clickable..

jasonfsmitty updated this object.

jasonfsmitty edited the test plan for this revision. (Show Details)

jasonfsmitty added a reviewer: epriestley.

jasonfsmitty added a subscriber: jasonfsmitty.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 23 2015, 1:20 PM

Herald added a subscriber: Korvin. · View Herald Transcript

I don't want to bring any changes to "Reports" usptream; it's basically frozen until it is replaced by Facts (T1562).

src/applications/maniphest/controller/ManiphestReportController.php
569	This is unused, and this approach won't scale for large numbers of tasks.

This revision now requires changes to proceed.Nov 2 2015, 4:40 PM

Remove used line of code

In D14318#160427, @epriestley wrote:

I don't want to bring any changes to "Reports" usptream; it's basically frozen until it is replaced by Facts (T1562).

Understood, thanks for the feedback!

I opened T9689 for the unit test failures, which appeared to be an issue with having auth.email-domains configured.

epriestley removed reviewers: epriestley, Blessed Reviewers.Nov 5 2015, 3:22 PM

joshuaspence added a subscriber: joshuaspence.Nov 13 2015, 9:39 AM

joshuaspence retitled this revision from Ref T9620: make all table entries clickable. to Make all table entries clickable.Nov 13 2015, 9:54 AM

joshuaspence updated this object.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestReportController.php

65 lines

Diff 34568

View Options

src/applications/maniphest/controller/ManiphestReportController.php

Make all table entries clickableNeeds ReviewPublicActions