HomePhabricator

Don't store IP addresses in content sources

Authored by epriestley.

Description

Don't store IP addresses in content sources

Summary:
We don't use these for anything, we're inconsistent about recording them, and there's some mild interaction with privacy concerns and data retention. Every other log we store any kind of information in can be given a custom retention policy after recent GC changes.

If we did put this back eventually it would probably be better to store a session identifier anyway, since that's more granular and more detailed.

You can fetch this info out of access logs anyway, too.

Test Plan: Left a couple of comments.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14315

Details

Committed
epriestleyOct 21 2015, 7:37 PM
Pushed
epriestleyOct 21 2015, 7:37 PM
Reviewer
chad
Differential Revision
D14315: Don't store IP addresses in content sources
Parents
rP5b619862cb06: Show a more reasonable status element for pull requests
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8369
Build 9605: Run Core Tests